Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: chrome/browser/chromeos/policy/system_log_uploader.cc

Issue 1216643002: Added unittests for SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed according to the main log uploader CL. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_uploader.cc
diff --git a/chrome/browser/chromeos/policy/system_log_uploader.cc b/chrome/browser/chromeos/policy/system_log_uploader.cc
index dc14006685ab7500172243f380ba41585397caf6..2995d41d96617850774a1b6817f9d493817fe864 100644
--- a/chrome/browser/chromeos/policy/system_log_uploader.cc
+++ b/chrome/browser/chromeos/policy/system_log_uploader.cc
@@ -8,17 +8,14 @@
#include "chrome/browser/chromeos/policy/system_log_delegate.h"
#include "chrome/browser/chromeos/policy/system_log_uploader.h"
-namespace {
+namespace policy {
// Determines the time between log uploads.
-const int64 kDefaultUploadDelayMs = 12 * 60 * 60 * 1000; // 12 hours
+const int64 SystemLogUploader::kDefaultUploadDelayMs =
+ 12 * 60 * 60 * 1000; // 12 hours
// Determines the time, measured from the time of last failed upload,
// after which the log upload is retried.
-const int64 kErrorUploadDelayMs = 120 * 1000; // 120 seconds
-
-} // namespace
-
-namespace policy {
+const int64 SystemLogUploader::kErrorUploadDelayMs = 120 * 1000; // 120 seconds
SystemLogUploader::SystemLogUploader(
const scoped_refptr<base::SequencedTaskRunner>& task_runner)
@@ -44,8 +41,8 @@ SystemLogUploadJob* SystemLogUploader::CreateSystemLogUploadJob() {
}
void SystemLogUploader::OnSuccess() {
- // On successful log upload schedule next log upload after upload_frequency_
- // time from now.
+ // On successful log upload schedule the next log upload after
+ // upload_frequency_ time from now.
upload_job_.reset();
retrying_ = true;
last_upload_attempt_ = base::Time::NowFromSystemTime();

Powered by Google App Engine
This is Rietveld 408576698