Added unittests for SystemLogUploader.

chrome/browser/chromeos/policy/system_log_uploader.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_util.h"
 #include "base/location.h"
 #include "base/strings/stringprintf.h"
 #include "base/task_runner_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/policy/system_log_uploader.h"
 #include "chrome/browser/chromeos/policy/upload_job_impl.h"
 #include "chrome/browser/chromeos/settings/device_oauth2_token_service.h"
 #include "chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/http/http_request_headers.h"
 
 namespace {
-// Determines the time between log uploads.
-const int64 kDefaultUploadDelayMs = 12 * 60 * 60 * 1000;  // 12 hours
-
-// Determines the time, measured from the time of last failed upload,
-// after which the log upload is retried.
-const int64 kErrorUploadDelayMs = 120 * 1000;  // 120 seconds
-
 // The maximum number of successive retries.
 const int kMaxNumRetries = 1;
 
 // String constant defining the url we upload system logs to.
 const char* kSystemLogUploadUrl =
     "https://m.google.com/devicemanagement/data/api/upload";
 
-// String constant identifying the header field which stores the file type.
-const char* kFileTypeHeaderName = "File-Type";
-
-// String constant signalling that the data segment contains log files.
-const char* const kFileTypeLogFile = "log_file";
-
-// String constant signalling that the segment contains a plain text.
-const char* const kContentTypePlainText = "text/plain";
-
-// Template string constant for populating the name field.
-const char* const kNameFieldTemplate = "file%d";
-
 // The file names of the system logs to upload.
 // Note: do not add anything to this list without checking for PII in the file.
 const char* const kSystemLogFileNames[] = {
     "/var/log/bios_info.txt", "/var/log/chrome/chrome",
     "/var/log/eventlog.txt",  "/var/log/messages",
     "/var/log/net.log",       "/var/log/platform_info.txt",
     "/var/log/ui/ui.LATEST",  "/var/log/update_engine.log"};
 
 // Reads the system log files as binary files, stores the files as pairs
 // (file name, data) and returns. Called on blocking thread.
@@ skipping 60 matching lines @@
   return scoped_ptr<policy::UploadJob>(new policy::UploadJobImpl(
       upload_url, robot_account_id, device_oauth2_token_service,
       system_request_context, delegate,
       make_scoped_ptr(new policy::UploadJobImpl::RandomMimeBoundaryGenerator)));
 }
 
 }  // namespace
 
 namespace policy {
 
+// Determines the time between log uploads.
+const int64 SystemLogUploader::kDefaultUploadDelayMs =
+    12 * 60 * 60 * 1000;  // 12 hours
+
+// Determines the time, measured from the time of last failed upload,
+// after which the log upload is retried.
+const int64 SystemLogUploader::kErrorUploadDelayMs = 120 * 1000;  // 120 seconds
+
+// String constant identifying the header field which stores the file type.
+const char* const SystemLogUploader::kFileTypeHeaderName = "File-Type";
+
+// String constant signalling that the data segment contains log files.
+const char* const SystemLogUploader::kFileTypeLogFile = "log_file";
+
+// String constant signalling that the segment contains a plain text.
+const char* const SystemLogUploader::kContentTypePlainText = "text/plain";
+
+// Template string constant for populating the name field.
+const char* const SystemLogUploader::kNameFieldTemplate = "file%d";
+
 SystemLogUploader::SystemLogUploader(
     scoped_ptr<Delegate> syslog_delegate,
     const scoped_refptr<base::SequencedTaskRunner>& task_runner)
     : retry_count_(0),
       upload_frequency_(
           base::TimeDelta::FromMilliseconds(kDefaultUploadDelayMs)),
       task_runner_(task_runner),
       syslog_delegate_(syslog_delegate.Pass()),
       weak_factory_(this) {
   if (!syslog_delegate_)
@@ skipping 75 matching lines @@
       base::TimeDelta());
   // Ensure that we never have more than one pending delayed task.
   weak_factory_.InvalidateWeakPtrs();
   task_runner_->PostDelayedTask(FROM_HERE,
                                 base::Bind(&SystemLogUploader::StartLogUpload,
                                            weak_factory_.GetWeakPtr()),
                                 delay);
 }
 
 }  // namespace policy