Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc

Issue 12166002: Cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc
diff --git a/native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc b/native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc
index 7652946c2b671033243589c7d8eb717a6a53e5eb..ba0ca73a7ae8154e5b34d46eddf749c74f686633 100644
--- a/native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc
+++ b/native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc
@@ -215,15 +215,14 @@ size_t MountNodeHtml5Fs::GetSize() {
return static_cast<size_t>(info.size);
}
-MountNodeHtml5Fs::MountNodeHtml5Fs(Mount* mount, int ino, int dev,
- PP_Resource fileref_resource)
- : MountNode(mount, ino, dev),
+MountNodeHtml5Fs::MountNodeHtml5Fs(Mount* mount, PP_Resource fileref_resource)
+ : MountNode(mount),
fileref_resource_(fileref_resource),
fileio_resource_(0) {
}
-bool MountNodeHtml5Fs::Init(int mode, short uid, short gid) {
- if (!MountNode::Init(Mount::OpenModeToPermission(mode), uid, gid))
+bool MountNodeHtml5Fs::Init(int perm) {
+ if (!MountNode::Init(Mount::OpenModeToPermission(perm)))
return false;
fileio_resource_= mount_->ppapi()->GetFileIoInterface()->Create(
@@ -232,7 +231,7 @@ bool MountNodeHtml5Fs::Init(int mode, short uid, short gid) {
return false;
int32_t open_result = mount_->ppapi()->GetFileIoInterface()->Open(
- fileio_resource_, fileref_resource_, ModeToOpenFlags(mode),
+ fileio_resource_, fileref_resource_, ModeToOpenFlags(perm),
PP_BlockUntilComplete());
if (open_result != PP_OK)
return false;
@@ -240,7 +239,9 @@ bool MountNodeHtml5Fs::Init(int mode, short uid, short gid) {
return true;
}
-int MountNodeHtml5Fs::Close() {
+void MountNodeHtml5Fs::Destroy() {
+ FSync();
+
if (fileio_resource_) {
mount_->ppapi()->GetFileIoInterface()->Close(fileio_resource_);
mount_->ppapi()->ReleaseResource(fileio_resource_);
@@ -249,5 +250,5 @@ int MountNodeHtml5Fs::Close() {
mount_->ppapi()->ReleaseResource(fileref_resource_);
fileio_resource_ = 0;
fileref_resource_ = 0;
- return 0;
+ MountNode::Destroy();
}

Powered by Google App Engine
This is Rietveld 408576698