Issue 12166002: Cleanup

Issue 12166002: Cleanup (Closed)

Created:
7 years, 10 months ago by noelallen1

Modified:
7 years, 10 months ago

Reviewers:
binji

CC:
chromium-reviews, binji, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Additional cleanup Additional cleanup/consolidation discovered as part of adding manifest files to the MountHttp. BUG=173525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180220

Patch Set 3 : merge #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -175 lines)			Patch
native_client_sdk/src/libraries/nacl_mounts/inode_pool.h	View		1 chunk	+65 lines, -0 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/library.dsc	View		1 chunk	+1 line, -0 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount.h	View	1	3 chunks	+7 lines, -10 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount.cc	View		2 chunks	+8 lines, -19 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc	View	1	11 chunks	+28 lines, -24 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_html5fs.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_http.cc	View		6 chunks	+9 lines, -19 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_mem.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_mem.cc	View		1 chunk	+4 lines, -34 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node.h	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node.cc	View		1 chunk	+12 lines, -16 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node_dir.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node_dir.cc	View		2 chunks	+4 lines, -9 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc	View		4 chunks	+9 lines, -8 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node_mem.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/mount_node_mem.cc	View		1 chunk	+3 lines, -8 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts/osstat.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts_test/mount_html5fs_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts_test/mount_node_test.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
native_client_sdk/src/libraries/nacl_mounts_test/mount_test.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

noelallen1

Remove dev & ino from init call, compute those OnMountNodeCreated. Move inode pool to Mount ...

7 years, 10 months ago (2013-02-01 23:54:23 UTC) #1

binji

lgtm https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc File native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc (right): https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc#newcode34 native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc:34: NullNode(Mount* mount); explicit https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/libraries/nacl_mounts/mount_mem.h File native_client_sdk/src/libraries/nacl_mounts/mount_mem.h (right): https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/libraries/nacl_mounts/mount_mem.h#newcode34 ...

7 years, 10 months ago (2013-02-02 00:04:44 UTC) #2

noelallen1

7 years, 10 months ago (2013-02-04 18:40:06 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc (right):

https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc:34: NullNode(Mount*
mount);
On 2013/02/02 00:04:44, binji wrote:
> explicit

Done.

https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_mounts/mount_mem.h (right):

https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_mounts/mount_mem.h:34: 
On 2013/02/02 00:04:44, binji wrote:
> nit: extra line

Done.

https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.h (right):

https://codereview.chromium.org/12166002/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.h:29: virtual
bool Init(int mode);
On 2013/02/02 00:04:44, binji wrote:
> int perm

Done.

Expand Messages | Collapse Messages