Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1216593003: [turbofan] Optimize string "length" property access based on types. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize string "length" property access based on types. Optimize string "length" property access based on static type information if possible, but also optimistically optimize the access based on type feedback from the LoadIC. R=jarin@chromium.org Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 Cr-Commit-Position: refs/heads/master@{#29543} Committed: https://crrev.com/b19f118c1675d3f4db8b3b63c9f6d98bbee7b32f Cr-Commit-Position: refs/heads/master@{#29588}

Patch Set 1 #

Patch Set 2 : Make GCC happy. #

Patch Set 3 : REBASE #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -2 lines) Patch
M BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +3 lines, -1 line 0 comments Download
A src/compiler/js-type-feedback-lowering.h View 1 1 chunk +62 lines, -0 lines 0 comments Download
A src/compiler/js-type-feedback-lowering.cc View 1 chunk +118 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +7 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/string-length.js View 1 chunk +31 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +30 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-08 09:33:14 UTC) #1
Benedikt Meurer
Hey Michi, This is the first step towards optimistic (cross-context) lowering in TurboFan. I put ...
5 years, 5 months ago (2015-07-08 09:35:00 UTC) #2
Jarin
lgtm from my side.
5 years, 5 months ago (2015-07-08 16:42:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216593003/20001
5 years, 5 months ago (2015-07-08 19:10:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 19:12:48 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 Cr-Commit-Position: refs/heads/master@{#29543}
5 years, 5 months ago (2015-07-08 19:13:06 UTC) #8
adamk
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1224083002/ by adamk@chromium.org. ...
5 years, 5 months ago (2015-07-08 21:29:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216593003/40001
5 years, 5 months ago (2015-07-09 12:40:52 UTC) #12
Benedikt Meurer
Patch triggered an existing bug on ARM debug. That should be resolved by now, so ...
5 years, 5 months ago (2015-07-09 12:41:31 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216593003/40001
5 years, 5 months ago (2015-07-09 13:46:23 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 13:47:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216593003/60001
5 years, 5 months ago (2015-07-13 05:32:30 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-13 06:02:21 UTC) #22
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 06:02:31 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b19f118c1675d3f4db8b3b63c9f6d98bbee7b32f
Cr-Commit-Position: refs/heads/master@{#29588}

Powered by Google App Engine
This is Rietveld 408576698