Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1216573008: Reland: Optimizes IndexedDB's DeleteDatabase when no db exists (Closed)

Created:
5 years, 5 months ago by jsbell
Modified:
5 years, 5 months ago
Reviewers:
cmumford
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Optimizes IndexedDB's DeleteDatabase when no db exists When deleting the non existing database in a origin with no existing backing store, then in DeleteDatabse(), early exiting before OpenBackingStore, so that it wont results in multiple transaction as earlier. Original patch by: payal.pandey This was reverted (see crrev.com/1071553002) when it appeared to make a test flaky, but the test continues to flake (now tracked as crbug.com/505609) so let's try relanding. BUG=460236 Committed: https://crrev.com/4cbc8f1b383fb8145056295176912d53030a98b0 Cr-Commit-Position: refs/heads/master@{#336796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jsbell
cmumford@ - PTAL?
5 years, 5 months ago (2015-06-29 22:19:14 UTC) #2
cmumford
lgtm Hit commit button
5 years, 5 months ago (2015-06-30 16:39:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216573008/1
5 years, 5 months ago (2015-06-30 16:40:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 16:46:29 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4cbc8f1b383fb8145056295176912d53030a98b0 Cr-Commit-Position: refs/heads/master@{#336796}
5 years, 5 months ago (2015-06-30 16:47:42 UTC) #9
vkuzkokov
5 years, 5 months ago (2015-07-02 16:18:10 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1225513002/ by vkuzkokov@chromium.org.

The reason for reverting is: Some bots still flaky. See crbug.com/506467.

Powered by Google App Engine
This is Rietveld 408576698