Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1216543004: X87: Make context register implicit for CallInterfaceDescriptors (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Make context register implicit for CallInterfaceDescriptors port 7015fd20531ee8498352f82d626c78023a1f6857 (r29402) original commit message: Up until now the context register was listed explicitly in each stub's CallInterfaceDescriptor. This was problematic, because it was listed first in the list of register parameters--which is fine for Crankshaft, which is more or less built to handle the context as the first parameter-- but not ideal for TurboFan, which adds the context at the end of all function parameters. Now the context register is no longer in the register list and can be handled appropriately by both compilers. Specifically, this allows the FunctionType specified for each CallInterfaceDescriptor to exactly match the parameter register list. BUG= Committed: https://crrev.com/70bb2372a223242440837e4d432548f7e40152e1 Cr-Commit-Position: refs/heads/master@{#29433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -45 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 15 chunks +27 lines, -36 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +10 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-02 02:43:38 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-02 03:40:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216543004/1
5 years, 5 months ago (2015-07-02 03:40:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 04:08:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 04:08:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70bb2372a223242440837e4d432548f7e40152e1
Cr-Commit-Position: refs/heads/master@{#29433}

Powered by Google App Engine
This is Rietveld 408576698