Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: sky/sdk/lib/widgets/toggleable.dart

Issue 1216533003: Remove the pointless second argument to animate() in AnimatedValue. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 6
7 import '../animation/animated_value.dart'; 7 import '../animation/animated_value.dart';
8 import '../animation/curves.dart'; 8 import '../animation/curves.dart';
9 import 'animated_component.dart'; 9 import 'animated_component.dart';
10 import 'basic.dart'; 10 import 'basic.dart';
11 11
12 typedef void ValueChanged(value); 12 typedef void ValueChanged(value);
13 13
14 const double _kCheckDuration = 200.0; 14 const double _kCheckDuration = 200.0;
15 15
16 abstract class Toggleable extends AnimatedComponent { 16 abstract class Toggleable extends AnimatedComponent {
17 17
18 Toggleable({ 18 Toggleable({
19 String key, 19 String key,
20 this.value, 20 this.value,
21 this.onChanged 21 this.onChanged
22 }) : super(key: key) { 22 }) : super(key: key) {
23 toggleAnimation = new AnimatedValue(value ? 1.0 : 0.0); 23 toggleAnimation = new AnimatedValue(value ? 1.0 : 0.0);
24 watch(toggleAnimation);
24 } 25 }
25 26
26 bool value; 27 bool value;
27 AnimatedValue toggleAnimation; 28 AnimatedValue toggleAnimation;
28 ValueChanged onChanged; 29 ValueChanged onChanged;
29 30
30 void syncFields(Toggleable source) { 31 void syncFields(Toggleable source) {
31 onChanged = source.onChanged; 32 onChanged = source.onChanged;
32 if (value != source.value) { 33 if (value != source.value) {
33 value = source.value; 34 value = source.value;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 height: size.height, 66 height: size.height,
66 child: new CustomPaint( 67 child: new CustomPaint(
67 token: toggleAnimation.value, 68 token: toggleAnimation.value,
68 callback: customPaintCallback 69 callback: customPaintCallback
69 ) 70 )
70 ), 71 ),
71 onGestureTap: _handleClick 72 onGestureTap: _handleClick
72 ); 73 );
73 } 74 }
74 } 75 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698