Issue 1216533003: Remove the pointless second argument to animate() in AnimatedValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216533003: Remove the pointless second argument to animate() in AnimatedValue. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove the pointless second argument to animate() in AnimatedValue. - Rename animate() to watch(). - Fix Toggleable to actually be animated (previously, it was essentially luck that let it be animated -- it was piggy-backing on the splash, I think). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9bb9c0bbe27ed24fede129c9d0f8adc6e265197e

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -25 lines)			Patch
M	sky/sdk/lib/widgets/animated_component.dart	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/widgets/drawer.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu.dart	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	sky/sdk/lib/widgets/toggleable.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-26 16:18:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9bb9c0bbe27ed24fede129c9d0f8adc6e265197e (presubmit successful).