sky/sdk/lib/rendering/README.md - Issue 1216533002: Add a note about sizedByParent's use. One day we should audit our RenderBoxes and see if any of the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/rendering/README.md

Issue 1216533002: Add a note about sizedByParent's use. One day we should audit our RenderBoxes and see if any of the… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/rendering/README.md

diff --git a/sky/sdk/lib/rendering/README.md b/sky/sdk/lib/rendering/README.md

index e63e8075efce9474141d16fc8629c08597addf33..887f9de33564af068be314a8cc516bdadaa0431b 100644

--- a/sky/sdk/lib/rendering/README.md

+++ b/sky/sdk/lib/rendering/README.md

@@ -259,7 +259,10 @@ A `RenderBox` subclass is required to implement the following contract:

The `sizedByParent` distinction is purely a performance

optimisation. It allows nodes that only set their size based on the

incoming constraints to skip that logic when they need to be

- re-laid-out.

+ re-laid-out, and, more importantly, it allows the layout system to

+ treat the node as a _layout boundary_, which reduces the amount of

+ work that needs to happen when the node is marked as needing

+ layout.

* The following methods must report numbers consistent with the output

of the layout algorithm used:

« no previous file with comments | « no previous file | no next file » | no next file with comments »