Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216493002: Rebaseline tests for crbug.com/382491. (Closed)

Created:
5 years, 6 months ago by chrishtr
Modified:
5 years, 5 months ago
Reviewers:
f(malita), fs
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebaseline tests for crbug.com/382491. Move one of them that still fails to a new bug. BUG=382491 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198005

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
chrishtr
Bot results: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/68619/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/60827/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/68370/layout-test-results/results.html
5 years, 6 months ago (2015-06-25 23:12:46 UTC) #2
chrishtr
Bot results: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/68619/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/60827/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/68370/layout-test-results/results.html
5 years, 6 months ago (2015-06-25 23:12:46 UTC) #3
fs
LGTM % issue 504613 and other expected differences (non-AA outlines)
5 years, 6 months ago (2015-06-26 08:37:37 UTC) #4
f(malita)
LGTM % border-antialiasing.html https://codereview.chromium.org/1216493002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1216493002/diff/20001/LayoutTests/TestExpectations#newcode8 LayoutTests/TestExpectations:8: crbug.com/382491 fast/borders/border-antialiasing.html [ NeedsRebaseline ] I ...
5 years, 6 months ago (2015-06-26 13:54:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216493002/40001
5 years, 6 months ago (2015-06-26 23:30:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216493002/40001
5 years, 5 months ago (2015-06-29 16:39:46 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198005
5 years, 5 months ago (2015-06-29 17:43:11 UTC) #12
chrishtr
5 years, 5 months ago (2015-06-29 23:59:11 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/1216493002/diff/20001/LayoutTests/TestExpecta...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1216493002/diff/20001/LayoutTests/TestExpecta...
LayoutTests/TestExpectations:8: crbug.com/382491
fast/borders/border-antialiasing.html [ NeedsRebaseline ]
On 2015/06/26 at 13:54:09, f(malita) wrote:
> I think this one should be reassigned to
https://code.google.com/p/chromium/issues/detail?id=502531
> 
> (current scaled-down outlines look horrible without aa)

Done.

Powered by Google App Engine
This is Rietveld 408576698