Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: src/runtime.js

Issue 1216463003: [strong] Implement strong mode semantics for the count operation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback + eliminate runtime check Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ppc/full-codegen-ppc.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.js
diff --git a/src/runtime.js b/src/runtime.js
index 00b57612e828a1601337a9a45b26288fc79e751e..ed7cd0b8a2008ca5d06a5cb24d5dd65dd2073f0d 100644
--- a/src/runtime.js
+++ b/src/runtime.js
@@ -211,7 +211,7 @@ COMPARE_STRONG = function COMPARE_STRONG(x, ncr) {
if (IS_STRING(this) && IS_STRING(x)) return %_StringCompare(this, x);
if (IS_NUMBER(this) && IS_NUMBER(x)) return %NumberCompare(this, x, ncr);
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -246,7 +246,7 @@ ADD_STRONG = function ADD_STRONG(x) {
if (IS_NUMBER(this) && IS_NUMBER(x)) return %NumberAdd(this, x);
if (IS_STRING(this) && IS_STRING(x)) return %_StringAdd(this, x);
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -270,7 +270,7 @@ STRING_ADD_LEFT_STRONG = function STRING_ADD_LEFT_STRONG(y) {
if (IS_STRING(y)) {
return %_StringAdd(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -295,7 +295,7 @@ STRING_ADD_RIGHT_STRONG = function STRING_ADD_RIGHT_STRONG(y) {
if (IS_STRING(this)) {
return %_StringAdd(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -312,7 +312,7 @@ SUB_STRONG = function SUB_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberSub(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -329,7 +329,7 @@ MUL_STRONG = function MUL_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberMul(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -346,7 +346,7 @@ DIV_STRONG = function DIV_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberDiv(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -363,7 +363,7 @@ MOD_STRONG = function MOD_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberMod(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -385,7 +385,7 @@ BIT_OR_STRONG = function BIT_OR_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberOr(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -416,7 +416,7 @@ BIT_AND_STRONG = function BIT_AND_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberAnd(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -433,7 +433,7 @@ BIT_XOR_STRONG = function BIT_XOR_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberXor(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -450,7 +450,7 @@ SHL_STRONG = function SHL_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberShl(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -481,7 +481,7 @@ SAR_STRONG = function SAR_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberSar(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
@@ -498,7 +498,7 @@ SHR_STRONG = function SHR_STRONG(y) {
if (IS_NUMBER(this) && IS_NUMBER(y)) {
return %NumberShr(this, y);
}
- throw %MakeTypeError(kStrongImplicitCast);
+ throw %MakeTypeError(kStrongImplicitConversion);
}
« no previous file with comments | « src/ppc/full-codegen-ppc.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698