src/ic/ic-state.cc - Issue 1216463003: [strong] Implement strong mode semantics for the count operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic-state.cc

Issue 1216463003: [strong] Implement strong mode semantics for the count operation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback + eliminate runtime check Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic-state.cc

diff --git a/src/ic/ic-state.cc b/src/ic/ic-state.cc

index 2de29ad516b8840cc74677856362c2c76993af85..8ab08bc08d2009a42db2323e3bbebb4632c04e49 100644

--- a/src/ic/ic-state.cc

+++ b/src/ic/ic-state.cc

@@ -223,6 +223,7 @@ Type* BinaryOpICState::GetResultType(Zone* zone) const {

std::ostream& operator<<(std::ostream& os, const BinaryOpICState& s) {

os << "(" << Token::Name(s.op_);

if (s.CouldCreateAllocationMementos()) os << "_CreateAllocationMementos";

+ if (is_strong(s.strength())) os << "_Strong";

os << ":" << BinaryOpICState::KindToString(s.left_kind_) << "*";

if (s.fixed_right_arg_.IsJust()) {

os << s.fixed_right_arg_.FromJust();

« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/messages.h » ('j') | no next file with comments »