extensions/browser/script_execution_observer.h - Issue 1216453002: [Extensions] Handle some funny cases in script injection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/script_execution_observer.h

Issue 1216453002: [Extensions] Handle some funny cases in script injection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/executescript/removed_frames/test.js ('k') | extensions/browser/script_executor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/script_execution_observer.h

diff --git a/extensions/browser/script_execution_observer.h b/extensions/browser/script_execution_observer.h

index 4edd99533ec5b0ba83eb5c35359e54757c180026..4204f137bd83cf1fca7a65730db6940c6d9dc3d8 100644

--- a/extensions/browser/script_execution_observer.h

+++ b/extensions/browser/script_execution_observer.h

@@ -27,9 +27,9 @@ class ScriptExecutionObserver {

// Called when script(s) have executed on a page.

// |executing_scripts_map| contains all extensions that are executing

- // scripts, mapped to the paths for those scripts. This may be an empty set

- // if the script has no path associated with it (e.g. in the case of

- // tabs.executeScript).

+ // scripts, mapped to the paths for those scripts. The paths may be an empty

+ // set if the script has no path associated with it (e.g. in the case of

+ // tabs.executeScript), but there will still be an entry for the extension.

virtual void OnScriptsExecuted(

const content::WebContents* web_contents,

const ExecutingScriptsMap& executing_scripts_map,

« no previous file with comments | « chrome/test/data/extensions/api_test/executescript/removed_frames/test.js ('k') | extensions/browser/script_executor.cc » ('j') | no next file with comments »