chrome/test/data/extensions/api_test/executescript/removed_frames/manifest.json - Issue 1216453002: [Extensions] Handle some funny cases in script injection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/executescript/removed_frames/manifest.json

Issue 1216453002: [Extensions] Handle some funny cases in script injection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ben's Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/executescript/removed_frames/inner.html ('k') | chrome/test/data/extensions/api_test/executescript/removed_frames/outer.html » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "version": "1.0.0.0",	2 "version": "1.0.0.0",

3 "manifest_version": 2,	3 "manifest_version": 2,

4 "name": "Subframes on load",	4 "name": "Subframes on load",

5 "description": "Test that calling executeScript on a tab that has completed it s load injects into subframes.",	5 "description": "Test that calling executeScript on a tab that has completed it s load injects into subframes.",

6 "background": {	6 "background": {

7 "scripts": ["test.js"]	7 "scripts": ["test.js"]

8 },	8 },

9 "permissions": ["tabs", "http://a.com/"]	9 "permissions": ["tabs", "http://a.com/", "webNavigation"]

10 }	10 }

OLD	NEW