[Chromecast] Add net logging.

[Chromecast] Add net logging.

Adds ShellNetLog to URLRequestContextGetters.

BUG=internal b/21900278

Committed: https://crrev.com/8ac56a2a2a14877b49d56a19a2e3396bca48a207
Cr-Commit-Position: refs/heads/master@{#336426}

[derekjchow1, 2015-06-26 01:03:03]

derekjchow@chromium.org changed reviewers:
+ gunsch@chromium.org

[derekjchow1, 2015-06-26 01:03:04]

PTAL.

I considered trying to reuse ShellNetLog, but that adds a dependency on
content/shell (and therefore content_shell_lib). I don't think we want to link
in content_shell_lib, so I created our own NetLog.

We should consider merging though. Ours is so similar to ShellNetLog that
Rietveld actually diffs cast_net_log.cc against shell_net_log.cc. There's was
also a TODO to merge with ChromeNetLog.

[lcwu1, 2015-06-26 04:30:25]

lcwu@chromium.org changed reviewers:
+ lcwu@chromium.org

[lcwu1, 2015-06-26 04:30:27]

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
File chromecast/browser/cast_net_log.cc (right):

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
chromecast/browser/cast_net_log.cc:55: #if defined(OS_WIN)
Cast doesn't care about OS_WIN. :-)

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
File chromecast/browser/cast_net_log.h (right):

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
chromecast/browser/cast_net_log.h:17: explicit CastNetLog();
No need for 'explicit'.

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/url_...
File chromecast/browser/url_request_context_factory.h (right):

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/url_...
chromecast/browser/url_request_context_factory.h:118: scoped_ptr<net::NetLog>
net_log_;
Any reason why you don'y want to create the NetLog object in brower_main_parts
like content shell does so that content browser client can pass it to other
potential users (such as devtools)?

[derekjchow1, 2015-06-26 17:58:53]

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
File chromecast/browser/cast_net_log.cc (right):

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
chromecast/browser/cast_net_log.cc:55: #if defined(OS_WIN)
On 2015/06/26 04:30:26, lcwu1 wrote:
> Cast doesn't care about OS_WIN. :-)

Done.

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
File chromecast/browser/cast_net_log.h (right):

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/cast...
chromecast/browser/cast_net_log.h:17: explicit CastNetLog();
On 2015/06/26 04:30:26, lcwu1 wrote:
> No need for 'explicit'.

Done.

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/url_...
File chromecast/browser/url_request_context_factory.h (right):

https://codereview.chromium.org/1216443002/diff/40001/chromecast/browser/url_...
chromecast/browser/url_request_context_factory.h:118: scoped_ptr<net::NetLog>
net_log_;
On 2015/06/26 04:30:26, lcwu1 wrote:
> Any reason why you don'y want to create the NetLog object in brower_main_parts
> like content shell does so that content browser client can pass it to other
> potential users (such as devtools)?

Done.

[gunsch, 2015-06-26 18:16:48]

lgtm, thanks!

[derekjchow1, 2015-06-26 18:40:23]

The CQ bit was checked by derekjchow@chromium.org

[commit-bot: I haz the power, 2015-06-26 18:40:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216443002/80001

[commit-bot: I haz the power, 2015-06-26 18:50:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-26 18:51:50]

Patchset 5 (id:??) landed as
https://crrev.com/8ac56a2a2a14877b49d56a19a2e3396bca48a207
Cr-Commit-Position: refs/heads/master@{#336426}