Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 // This file contains macros to simplify histogram reporting from the disk | 5 // This file contains macros to simplify histogram reporting from the disk |
| 6 // cache. The main issue is that we want to have separate histograms for each | 6 // cache. The main issue is that we want to have separate histograms for each |
| 7 // type of cache (regular vs. media, etc), without adding the complexity of | 7 // type of cache (regular vs. media, etc), without adding the complexity of |
| 8 // keeping track of a potentially large number of histogram objects that have to | 8 // keeping track of a potentially large number of histogram objects that have to |
| 9 // survive the backend object that created them. | 9 // survive the backend object that created them. |
| 10 | 10 |
| 11 #ifndef NET_DISK_CACHE_HISTOGRAM_MACROS_H_ | 11 #ifndef NET_DISK_CACHE_V2_HISTOGRAM_MACROS_H_ |
| 12 #define NET_DISK_CACHE_HISTOGRAM_MACROS_H_ | 12 #define NET_DISK_CACHE_V2_HISTOGRAM_MACROS_H_ |
| 13 | 13 |
| 14 // ----------------------------------------------------------------------------- | 14 // ----------------------------------------------------------------------------- |
| 15 | 15 |
| 16 // These histograms follow the definition of UMA_HISTOGRAMN_XXX except that | 16 // These histograms follow the definition of UMA_HISTOGRAMN_XXX except that |
| 17 // whenever the name changes (the experiment group changes), the histrogram | 17 // whenever the name changes (the experiment group changes), the histrogram |
| 18 // object is re-created. | 18 // object is re-created. |
| 19 // Note: These macros are only run on one thread, so the declarations of | 19 // Note: These macros are only run on one thread, so the declarations of |
| 20 // |counter| was made static (i.e., there will be no race for reinitialization). | 20 // |counter| was made static (i.e., there will be no race for reinitialization). |
| 21 | 21 |
| 22 #define CACHE_HISTOGRAM_CUSTOM_COUNTS(name, sample, min, max, bucket_count) \ | 22 #define CACHE_HISTOGRAM_CUSTOM_COUNTS(name, sample, min, max, bucket_count) \ |
| (...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 77 (base::Time::Now() - initial_time).InHours()) | 77 (base::Time::Now() - initial_time).InHours()) |
| 78 | 78 |
| 79 // HISTOGRAM_AGE_MS will collect time elapsed since |initial_time|, with the | 79 // HISTOGRAM_AGE_MS will collect time elapsed since |initial_time|, with the |
| 80 // normal resolution of the UMA_HISTOGRAM_TIMES. | 80 // normal resolution of the UMA_HISTOGRAM_TIMES. |
| 81 #define CACHE_HISTOGRAM_AGE_MS(name, initial_time)\ | 81 #define CACHE_HISTOGRAM_AGE_MS(name, initial_time)\ |
| 82 CACHE_HISTOGRAM_TIMES(name, base::TimeTicks::Now() - initial_time) | 82 CACHE_HISTOGRAM_TIMES(name, base::TimeTicks::Now() - initial_time) |
| 83 | 83 |
| 84 #define CACHE_HISTOGRAM_CACHE_ERROR(name, sample) \ | 84 #define CACHE_HISTOGRAM_CACHE_ERROR(name, sample) \ |
| 85 CACHE_HISTOGRAM_ENUMERATION(name, sample, 50) | 85 CACHE_HISTOGRAM_ENUMERATION(name, sample, 50) |
| 86 | 86 |
| 87 #ifdef NET_DISK_CACHE_BACKEND_IMPL_CC_ | 87 #ifdef NET_DISK_CACHE_V2_BACKEND_IMPL_CC_ |
|
rvargas (doing something else)
2014/02/06 04:21:23
no version prefix
gavinp
2014/02/09 15:13:35
This problematic #define is being dealt with in an
| |
| 88 #define BACKEND_OBJ this | 88 #define BACKEND_OBJ this |
| 89 #else | 89 #else |
| 90 #define BACKEND_OBJ backend_ | 90 #define BACKEND_OBJ backend_ |
| 91 #endif | 91 #endif |
| 92 | 92 |
| 93 // Generates a UMA histogram of the given type, generating the proper name for | 93 // Generates a UMA histogram of the given type, generating the proper name for |
| 94 // it (asking backend_->HistogramName), and adding the provided sample. | 94 // it (asking backend_->HistogramName), and adding the provided sample. |
| 95 // For example, to generate a regualar UMA_HISTOGRAM_COUNTS, this macro would | 95 // For example, to generate a regualar UMA_HISTOGRAM_COUNTS, this macro would |
| 96 // be used as: | 96 // be used as: |
| 97 // CACHE_UMA(COUNTS, "MyName", 0, 20); | 97 // CACHE_UMA(COUNTS, "MyName", 0, 20); |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 117 break;\ | 117 break;\ |
| 118 case net::PNACL_CACHE:\ | 118 case net::PNACL_CACHE:\ |
| 119 CACHE_HISTOGRAM_##type(my_name.data(), sample);\ | 119 CACHE_HISTOGRAM_##type(my_name.data(), sample);\ |
| 120 break;\ | 120 break;\ |
| 121 default:\ | 121 default:\ |
| 122 NOTREACHED();\ | 122 NOTREACHED();\ |
| 123 break;\ | 123 break;\ |
| 124 }\ | 124 }\ |
| 125 } | 125 } |
| 126 | 126 |
| 127 #endif // NET_DISK_CACHE_HISTOGRAM_MACROS_H_ | 127 #endif // NET_DISK_CACHE_V2_HISTOGRAM_MACROS_H_ |
| OLD | NEW |