third_party/iaccessible2/BUILD.gn - Issue 1216413002: Fix remaining warnings for -Wmissing-braces and enable on win clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/iaccessible2/BUILD.gn

Issue 1216413002: Fix remaining warnings for -Wmissing-braces and enable on win clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moo Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/iaccessible2/BUILD.gn

diff --git a/third_party/iaccessible2/BUILD.gn b/third_party/iaccessible2/BUILD.gn

index 6ebcee644d3d0c166e4fefc5a5a73e1de95f5892..902667464257dfef2b771b02e4112a2cd6fe80e9 100644

--- a/third_party/iaccessible2/BUILD.gn

+++ b/third_party/iaccessible2/BUILD.gn

@@ -20,8 +20,15 @@ shared_library("IAccessible2Proxy") {

"IAccessible2Proxy.def",

]

+ config("IAccessible2Proxy_warnings") {

+ if (is_clang) {

+ # MIDL generated code has a habit of omitting optional braces.

+ cflags = [ "-Wno-missing-braces" ]

+ }

configs -= [ "//build/config/compiler:chromium_code" ]

configs += [ "//build/config/compiler:no_chromium_code" ]

+ configs += [ ":IAccessible2Proxy_warnings" ]

dcheng 2015/07/08 02:39:09 I don't really know why, but the GYP file didn't n

Nico 2015/07/08 02:45:38 waaaaat

defines = [ "REGISTER_PROXY_DLL" ]

« components/policy/core/common/policy_loader_win.cc ('K') | « third_party/cld_2/cld_2.gyp ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | no next file with comments »