Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1216373002:
[turbofan] Ship TF for try-catch statements. (Closed)
|
Created:
5 years, 5 months ago by Michael Starzinger Modified:
5 years, 5 months ago Reviewers:
Michael Hablich CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Ship TF for try-catch statements.
R=hablich@chromium.org
BUG=v8:4131
LOG=N
Committed: https://crrev.com/1251d02e7bb2a13ae5cf6fda5d3403730d2ae12f
Cr-Commit-Position: refs/heads/master@{#29708}
Patch Set 1 #
Messages
Total messages: 20 (6 generated)
mstarzinger@chromium.org changed reviewers: + hablich@chromium.org
Michael: As discussed offline, feel free to CQ this when we decide to ship try-catch.
On 2015/07/02 at 09:37:20, mstarzinger wrote: > Michael: As discussed offline, feel free to CQ this when we decide to ship try-catch. Heads-up: going to submit this on Monday so it does not interfere with Dev.
On 2015/07/16 at 12:55:09, Hablich wrote: > On 2015/07/02 at 09:37:20, mstarzinger wrote: > > Michael: As discussed offline, feel free to CQ this when we decide to ship try-catch. > > Heads-up: going to submit this on Monday so it does not interfere with Dev. To correct myself: Next dev will be build from 45 so there should be no problem.
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216373002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216373002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...) (exceeded global retry quota)
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216373002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1251d02e7bb2a13ae5cf6fda5d3403730d2ae12f Cr-Commit-Position: refs/heads/master@{#29708}
Message was sent while issue was closed.
On 2015/07/16 15:39:51, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/1251d02e7bb2a13ae5cf6fda5d3403730d2ae12f > Cr-Commit-Position: refs/heads/master@{#29708} Looks like this might have caused a regression: The octane gbemu-part1 test timed out. Could it be from increased compilation time? http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20g...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1234363003/ by adamk@chromium.org. The reason for reverting is: Causes gbemu-part1 to time out on Linux dbg builders http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/... http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20c... http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20g....
Message was sent while issue was closed.
On 2015/07/16 19:41:37, adamk wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1234363003/ by mailto:adamk@chromium.org. > > The reason for reverting is: Causes gbemu-part1 to time out on Linux dbg > builders > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/... > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20c... > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20g.... Also caused a layout test failure: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
