Issue 1216323002: Add a TabNavigator to the Stocks demo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216323002: Add a TabNavigator to the Stocks demo (Closed)

Created:
5 years, 5 months ago by hansmuller1

Modified:
5 years, 5 months ago

Reviewers:
hansmuller, Hixie, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add a TabNavigator to the Stocks demo Changed FixedHeightScrollable so that if the list shrinks past the current scrollOffset, the scrollOffset is adjusted so that the last/only page of the list remains visible. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1751c826be371deaeeb8e6e8dba7b43634f2ee8d

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -21 lines)			Patch
M	sky/sdk/example/stocks/lib/stock_home.dart	View	4 chunks	+33 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/editing/editable_text.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/fixed_height_scrollable.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	sky/tests/examples/stocks-expected.txt	View	2 chunks	+58 lines, -18 lines	0 comments	Download

Total messages: 7 (4 generated)

hansmuller1

5 years, 5 months ago (2015-07-01 00:08:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
1751c826be371deaeeb8e6e8dba7b43634f2ee8d (presubmit successful).