Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: base/prefs/public/pref_service_base.h

Issue 12163003: Add FilePath to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/json_pref_store.h ('k') | base/scoped_native_library.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/public/pref_service_base.h
diff --git a/base/prefs/public/pref_service_base.h b/base/prefs/public/pref_service_base.h
index 4115fa4070389709ae40ce707b0733ed38c6f169..3508f402e194e5a693a5b49025c4cfc32b776ca0 100644
--- a/base/prefs/public/pref_service_base.h
+++ b/base/prefs/public/pref_service_base.h
@@ -18,6 +18,10 @@
#include "base/values.h"
+namespace base {
+class FilePath;
+}
+
namespace content {
class BrowserContext;
}
@@ -26,7 +30,6 @@ namespace subtle {
class PrefMemberBase;
}
-class FilePath;
class PrefObserver;
class PrefServiceBase {
@@ -118,7 +121,7 @@ class PrefServiceBase {
virtual int GetInteger(const char* path) const = 0;
virtual double GetDouble(const char* path) const = 0;
virtual std::string GetString(const char* path) const = 0;
- virtual FilePath GetFilePath(const char* path) const = 0;
+ virtual base::FilePath GetFilePath(const char* path) const = 0;
// Returns the branch if it exists, or the registered default value otherwise.
// Note that |path| must point to a registered preference. In that case, these
@@ -140,7 +143,7 @@ class PrefServiceBase {
virtual void SetInteger(const char* path, int value) = 0;
virtual void SetDouble(const char* path, double value) = 0;
virtual void SetString(const char* path, const std::string& value) = 0;
- virtual void SetFilePath(const char* path, const FilePath& value) = 0;
+ virtual void SetFilePath(const char* path, const base::FilePath& value) = 0;
// Int64 helper methods that actually store the given value as a string.
// Note that if obtaining the named value via GetDictionary or GetList, the
« no previous file with comments | « base/prefs/json_pref_store.h ('k') | base/scoped_native_library.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698