Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8629)

Unified Diff: chrome/installer/test/alternate_version_generator.h

Issue 12163003: Add FilePath to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/uninstall.h ('k') | chrome/installer/test/resource_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/test/alternate_version_generator.h
diff --git a/chrome/installer/test/alternate_version_generator.h b/chrome/installer/test/alternate_version_generator.h
index 0ae0d5c3725928bb352debfa9d356368b8d3dc0c..fe60a6a86b6726f779ecde0a4163bc6b9ef8fc74 100644
--- a/chrome/installer/test/alternate_version_generator.h
+++ b/chrome/installer/test/alternate_version_generator.h
@@ -9,9 +9,12 @@
#include <string>
-class FilePath;
class Version;
+namespace base {
+class FilePath;
+}
+
namespace upgrade_test {
enum Direction {
@@ -25,8 +28,8 @@ enum Direction {
// |target_path| is clobbered. Returns true on success. |original_version| and
// |new_version|, when non-NULL, are given the original and new version numbers
// on success.
-bool GenerateAlternateVersion(const FilePath& original_installer_path,
- const FilePath& target_path,
+bool GenerateAlternateVersion(const base::FilePath& original_installer_path,
+ const base::FilePath& target_path,
Direction direction,
std::wstring* original_version,
std::wstring* new_version);
@@ -35,16 +38,16 @@ bool GenerateAlternateVersion(const FilePath& original_installer_path,
// |target_file|, modifying the version of the copy according to |direction|.
// Any previous file at |target_file| is clobbered. Returns true on success.
// Note that |target_file| may still be mutated on failure.
-bool GenerateAlternatePEFileVersion(const FilePath& original_file,
- const FilePath& target_file,
+bool GenerateAlternatePEFileVersion(const base::FilePath& original_file,
+ const base::FilePath& target_file,
Direction direction);
// Given a path to a PEImage in |original_file|, copy that file to
// |target_file|, modifying the version of the copy according to |version|.
// Any previous file at |target_file| is clobbered. Returns true on success.
// Note that |target_file| may still be mutated on failure.
-bool GenerateSpecificPEFileVersion(const FilePath& original_file,
- const FilePath& target_file,
+bool GenerateSpecificPEFileVersion(const base::FilePath& original_file,
+ const base::FilePath& target_file,
const Version& version);
} // namespace upgrade_test
« no previous file with comments | « chrome/installer/setup/uninstall.h ('k') | chrome/installer/test/resource_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698