Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/download/download_path_reservation_tracker.h

Issue 12163003: Add FilePath to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_file_picker.h ('k') | chrome/browser/enumerate_modules_model_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_path_reservation_tracker.h
diff --git a/chrome/browser/download/download_path_reservation_tracker.h b/chrome/browser/download/download_path_reservation_tracker.h
index 9bfeea78e49845aceb0799043059de6efad1e19e..7c7775b063f5f9a4f2c007d97338183386eac2ab 100644
--- a/chrome/browser/download/download_path_reservation_tracker.h
+++ b/chrome/browser/download/download_path_reservation_tracker.h
@@ -63,12 +63,14 @@
// It considers 'foo/bar/x.pdf' and 'foo/baz/x.pdf' to be two different paths,
// even though 'bar' might be a symlink to 'baz'.
+namespace base {
+class FilePath;
+}
+
namespace content {
class DownloadItem;
}
-class FilePath;
-
// Issues and tracks download paths that are in use by the download system. When
// a target path is set for a download, this object tracks the path and the
// associated download item so that subsequent downloads can avoid using the
@@ -84,7 +86,7 @@ class DownloadPathReservationTracker {
//
// If |requested_target_path| was not writeable, then the parent directory of
// |target_path| may be different from that of |requested_target_path|.
- typedef base::Callback<void(const FilePath& target_path,
+ typedef base::Callback<void(const base::FilePath& target_path,
bool target_path_verified)> ReservedPathCallback;
// The largest index for the uniquification suffix that we will try while
@@ -99,14 +101,14 @@ class DownloadPathReservationTracker {
// directory does not exist and is the parent directory of
// |requested_target_path|, the directory will be created.
static void GetReservedPath(content::DownloadItem& download_item,
- const FilePath& requested_target_path,
- const FilePath& default_download_path,
+ const base::FilePath& requested_target_path,
+ const base::FilePath& default_download_path,
bool should_uniquify_path,
const ReservedPathCallback& callback);
// Returns true if |path| is in use by an existing path reservation. Should
// only be called on the FILE thread. Currently only used by tests.
- static bool IsPathInUseForTesting(const FilePath& path);
+ static bool IsPathInUseForTesting(const base::FilePath& path);
};
#endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PATH_RESERVATION_TRACKER_H_
« no previous file with comments | « chrome/browser/download/download_file_picker.h ('k') | chrome/browser/enumerate_modules_model_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698