chrome/browser/icon_manager_linux.cc - Issue 12163003: Add FilePath to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/icon_manager_linux.cc

Issue 12163003: Add FilePath to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/icon_manager_linux.cc

diff --git a/chrome/browser/icon_manager_linux.cc b/chrome/browser/icon_manager_linux.cc

index df7c62963fe6a9b4254b077a8928c54b1534d8e7..5dfa1554fb5bb21b1e56f5dbd61c98374372c151 100644

--- a/chrome/browser/icon_manager_linux.cc

+++ b/chrome/browser/icon_manager_linux.cc

@@ -7,7 +7,8 @@

#include "base/nix/mime_util_xdg.h"

#include "base/threading/thread_restrictions.h"

-IconGroupID IconManager::GetGroupIDFromFilepath(const FilePath& filepath) {

+IconGroupID IconManager::GetGroupIDFromFilepath(

+ const base::FilePath& filepath) {

// It turns out the call to base::nix::GetFileMimeType below does IO, but

// callers of GetGroupIDFromFilepath assume it does not do IO (the Windows

// and Mac implementations do not). We should fix this by either not doing IO