Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2056)

Unified Diff: chrome/common/logging_chrome.h

Issue 12163003: Add FilePath to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_l10n_util.h ('k') | chrome/common/mac/app_mode_chrome_locator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.h
diff --git a/chrome/common/logging_chrome.h b/chrome/common/logging_chrome.h
index dee2533671233ee2de9c12de0c9d4c3eacf5eee7..bde1793f793b6d122afd3ddc631f3313d707d72d 100644
--- a/chrome/common/logging_chrome.h
+++ b/chrome/common/logging_chrome.h
@@ -12,7 +12,10 @@
#include "base/time.h"
class CommandLine;
+
+namespace base {
class FilePath;
+}
namespace logging {
@@ -34,7 +37,7 @@ void InitChromeLogging(const CommandLine& command_line,
#if defined(OS_CHROMEOS)
// Get the log file location.
-FilePath GetSessionLogFile(const CommandLine& command_line);
+base::FilePath GetSessionLogFile(const CommandLine& command_line);
// Redirects chrome logging to the appropriate session log dir.
void RedirectChromeLogging(const CommandLine& command_line);
@@ -44,7 +47,7 @@ void RedirectChromeLogging(const CommandLine& command_line);
void CleanupChromeLogging();
// Returns the fully-qualified name of the log file.
-FilePath GetLogFileName();
+base::FilePath GetLogFileName();
// Returns true when error/assertion dialogs are to be shown,
// false otherwise.
@@ -64,8 +67,8 @@ size_t GetFatalAssertions(AssertionList* assertions);
// Inserts timestamp before file extension in the format
// "_yymmdd-hhmmss".
-FilePath GenerateTimestampedName(const FilePath& base_path,
- base::Time timestamp);
+base::FilePath GenerateTimestampedName(const base::FilePath& base_path,
+ base::Time timestamp);
} // namespace logging
#endif // CHROME_COMMON_LOGGING_CHROME_H_
« no previous file with comments | « chrome/common/extensions/extension_l10n_util.h ('k') | chrome/common/mac/app_mode_chrome_locator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698