Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3309)

Unified Diff: base/path_service.h

Issue 12163003: Add FilePath to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/nix/xdg_util.h ('k') | base/perftimer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/path_service.h
diff --git a/base/path_service.h b/base/path_service.h
index 8a7defe6e4ae7e4c0080d422349630a120da1235..832b92b15812325ce91c2b0f5fa426a901a6f86e 100644
--- a/base/path_service.h
+++ b/base/path_service.h
@@ -12,9 +12,8 @@
#include "base/gtest_prod_util.h"
#include "build/build_config.h"
-class FilePath;
-
namespace base {
+class FilePath;
class ScopedPathOverride;
} // namespace
@@ -30,7 +29,7 @@ class BASE_EXPORT PathService {
//
// Returns true if the directory or file was successfully retrieved. On
// failure, 'path' will not be changed.
- static bool Get(int key, FilePath* path);
+ static bool Get(int key, base::FilePath* path);
// Overrides the path to a special directory or file. This cannot be used to
// change the value of DIR_CURRENT, but that should be obvious. Also, if the
@@ -42,13 +41,13 @@ class BASE_EXPORT PathService {
//
// WARNING: Consumers of PathService::Get may expect paths to be constant
// over the lifetime of the app, so this method should be used with caution.
- static bool Override(int key, const FilePath& path);
+ static bool Override(int key, const base::FilePath& path);
// This function does the same as PathService::Override but it takes an extra
// parameter |create| which guides whether the directory to be overriden must
// be created in case it doesn't exist already.
static bool OverrideAndCreateIfNeeded(int key,
- const FilePath& path,
+ const base::FilePath& path,
bool create);
// To extend the set of supported keys, you can register a path provider,
@@ -59,7 +58,7 @@ class BASE_EXPORT PathService {
// WARNING: This function could be called on any thread from which the
// PathService is used, so a the ProviderFunc MUST BE THREADSAFE.
//
- typedef bool (*ProviderFunc)(int, FilePath*);
+ typedef bool (*ProviderFunc)(int, base::FilePath*);
// Call to register a path provider. You must specify the range "[key_start,
// key_end)" of supported path keys.
« no previous file with comments | « base/nix/xdg_util.h ('k') | base/perftimer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698