Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1216273002: Build stocks.skyx (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Build stocks.skyx This CL teaches the build system how to create the stocks.skyx application bundle. This bundle contains the stocks snapshot as well as the material design assets needed by the stocks app to run offline. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/afaa8899e5a9e4b1ba08544741086d31619434e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M sky/apk/rules.gni View 4 chunks +43 lines, -4 lines 0 comments Download
M sky/sdk/example/stocks/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-06-30 17:59:57 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-06-30 18:03:02 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-06-30 18:16:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afaa8899e5a9e4b1ba08544741086d31619434e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698