Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1216223004: Avoid using floating point when not needed. (Closed)

Created:
5 years, 5 months ago by mstensho (USE GERRIT)
Modified:
5 years, 5 months ago
Reviewers:
dsinclair, szager1
CC:
blink-reviews, szager+layoutwatch_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Avoid using floating point when not needed. Caused inaccuracies which made us think that we had one column more than we actually had, which in turn triggered an assertion failure. BUG=504158 R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198213

Patch Set 1 #

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
A + LayoutTests/fast/multicol/very-tall-block-crash.html View 1 chunk +1 line, -2 lines 0 comments Download
A + LayoutTests/fast/multicol/very-tall-block-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mstensho (USE GERRIT)
5 years, 5 months ago (2015-07-01 11:46:26 UTC) #1
szager1
There's still an implicit type conversion of the return value to unsigned int. You should ...
5 years, 5 months ago (2015-07-01 16:03:57 UTC) #3
mstensho (USE GERRIT)
On 2015/07/01 16:03:57, szager1 wrote: > There's still an implicit type conversion of the return ...
5 years, 5 months ago (2015-07-02 07:53:57 UTC) #4
dsinclair
lgtm
5 years, 5 months ago (2015-07-02 13:54:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216223004/20001
5 years, 5 months ago (2015-07-02 14:02:00 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 14:05:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198213

Powered by Google App Engine
This is Rietveld 408576698