base/files/file.cc - Issue 1216183004: Only set File::[tracing_]path_ when file tracing is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file.cc

Issue 1216183004: Only set File::[tracing_]path_ when file tracing is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/files/file.cc

diff --git a/base/files/file.cc b/base/files/file.cc

index 6dfeb9172fd3239f930575fe7f1f14bdc60af5f0..d3e6f3b86cfbd970580f5b65d5234508e03178c2 100644

--- a/base/files/file.cc

+++ b/base/files/file.cc

@@ -90,7 +90,8 @@ void File::Initialize(const FilePath& path, uint32 flags) {

error_details_ = FILE_ERROR_ACCESS_DENIED;

return;

}

- path_ = path;

+ if (FileTracing::IsCategoryEnabled())

+ path_ = path;

SCOPED_FILE_TRACE("Initialize");

DoInitialize(flags);

}

« no previous file with comments | « no previous file | base/files/file_tracing.h » ('j') | base/files/file_tracing.cc » ('J')