Only set File::[tracing_]path_ when file tracing is enabled.

Only set File::[tracing_]path_ when file tracing is enabled.

R=rvargas@chromium.org
BUG=none
TEST=less |path_| cruft lying around

Committed: https://crrev.com/fd5b108c82d56f6022dfbe62a023d1e81ff6f83b
Cr-Commit-Position: refs/heads/master@{#337168}

[Dan Beam, 2015-07-02 00:42:11]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-07-02 00:43:48]

https://codereview.chromium.org/1216183004/diff/20001/base/files/file_tracing.cc
File base/files/file_tracing.cc (left):

https://codereview.chromium.org/1216183004/diff/20001/base/files/file_tracing...
base/files/file_tracing.cc:43: if (!g_provider)
this should never happen

[rvargas (doing something else), 2015-07-02 01:01:59]

lgtm

[rvargas (doing something else), 2015-07-02 01:15:10]

Even better if it compiles!. lgtm.

[rvargas (doing something else), 2015-07-02 02:11:06]

lgtm with nits (that happens when I get to spend more time doing a review :p)

https://codereview.chromium.org/1216183004/diff/60001/base/files/file.h
File base/files/file.h (right):

https://codereview.chromium.org/1216183004/diff/60001/base/files/file.h#newco...
base/files/file.h:360: void DoInitialize(uint32 flags, const FilePath& path);
tiny nit: Do you mind going back to having path as the first argument?. I also
don't follow why are we documenting on the header that a private member is not
called when the path used is invalid. Granted, that is not part of this CL.

https://codereview.chromium.org/1216183004/diff/60001/base/files/file.h#newco...
base/files/file.h:374: // Path that |Initialize()| was called with. Only set if
safe (i.e. no '..')
I think the safe reference is stale at this point, no?. If the path is not safe,
Initialization will fail and IsValid() will return false, which means the object
is not usable at that point (do we really want to document something about a
member that is only used for tracing, with objects on that state?)

[Dan Beam, 2015-07-02 02:17:29]

Patchset #4 (id:80001) has been deleted

[Dan Beam, 2015-07-02 02:18:06]

https://codereview.chromium.org/1216183004/diff/60001/base/files/file.h
File base/files/file.h (right):

https://codereview.chromium.org/1216183004/diff/60001/base/files/file.h#newco...
base/files/file.h:360: void DoInitialize(uint32 flags, const FilePath& path);
On 2015/07/02 02:11:05, rvargas (out of office) wrote:
> tiny nit: Do you mind going back to having path as the first argument?. I also
> don't follow why are we documenting on the header that a private member is not
> called when the path used is invalid. Granted, that is not part of this CL.

Done.

https://codereview.chromium.org/1216183004/diff/60001/base/files/file.h#newco...
base/files/file.h:374: // Path that |Initialize()| was called with. Only set if
safe (i.e. no '..')
On 2015/07/02 02:11:06, rvargas (out of office) wrote:
> I think the safe reference is stale at this point, no?. If the path is not
safe,
> Initialization will fail and IsValid() will return false, which means the
object
> is not usable at that point (do we really want to document something about a
> member that is only used for tracing, with objects on that state?)

Done.

[Dan Beam, 2015-07-02 02:18:55]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-07-02 02:18:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rvargas@chromium.org
Link to the patchset: https://codereview.chromium.org/1216183004/#ps90001
(title: "it even compiles!")

[commit-bot: I haz the power, 2015-07-02 02:19:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216183004/90001

[commit-bot: I haz the power, 2015-07-02 03:33:18]

Committed patchset #4 (id:90001)

[commit-bot: I haz the power, 2015-07-02 03:34:17]

Patchset 4 (id:??) landed as
https://crrev.com/fd5b108c82d56f6022dfbe62a023d1e81ff6f83b
Cr-Commit-Position: refs/heads/master@{#337168}