Update gn bootstrap.py to handle latest chromium changes

Update gn bootstrap.py to handle latest chromium changes

A couple of recent changes seem to have caused it to
bit-rot.

Also, while tracking all these down I found it useful
to be able to re-use the temporary directory so I
added a --no-clean option that does just that.

Committed: https://crrev.com/9bcde38731a3156271ec58760b3168721abbd672
Cr-Commit-Position: refs/heads/master@{#337418}

[Sam Clegg, 2015-07-01 19:30:54]

sbc@chromium.org changed reviewers:
+ brettw@chromium.org

[Sam Clegg, 2015-07-01 19:33:01]

With this change the hermetic build of gn now works but then when trying to
re-build itself I get:

Building gn using itself to out/Release...
ERROR at //content/browser/tracing/BUILD.gn:33:5: Can't load input file.
    "//third_party/trace-viewer/tracing:generate_about_tracing",
    ^----------------------------------------------------------
Unable to load:
 
/usr/local/google/home/sbc/dev/chromium/src/third_party/trace-viewer/tracing/BUILD.gn
I also checked in the secondary tree for:
 
/usr/local/google/home/sbc/dev/chromium/src/build/secondary/third_party/trace-viewer/tracing/BUILD.gn

[Sam Clegg, 2015-07-01 19:37:55]

On 2015/07/01 19:33:01, Sam Clegg wrote:
> With this change the hermetic build of gn now works but then when trying to
> re-build itself I get:
> 
> Building gn using itself to out/Release...
> ERROR at //content/browser/tracing/BUILD.gn:33:5: Can't load input file.
>     "//third_party/trace-viewer/tracing:generate_about_tracing",
>     ^----------------------------------------------------------
> Unable to load:
>  
>
/usr/local/google/home/sbc/dev/chromium/src/third_party/trace-viewer/tracing/BUILD.gn
> I also checked in the secondary tree for:
>  
>
/usr/local/google/home/sbc/dev/chromium/src/build/secondary/third_party/trace-viewer/tracing/BUILD.gn

Syncing seems to have fix this.

This change should be good now.

Do we need a bot that runs this to avoid this bit-rot in future?

[Sam Clegg, 2015-07-01 19:37:55]

On 2015/07/01 19:33:01, Sam Clegg wrote:
> With this change the hermetic build of gn now works but then when trying to
> re-build itself I get:
> 
> Building gn using itself to out/Release...
> ERROR at //content/browser/tracing/BUILD.gn:33:5: Can't load input file.
>     "//third_party/trace-viewer/tracing:generate_about_tracing",
>     ^----------------------------------------------------------
> Unable to load:
>  
>
/usr/local/google/home/sbc/dev/chromium/src/third_party/trace-viewer/tracing/BUILD.gn
> I also checked in the secondary tree for:
>  
>
/usr/local/google/home/sbc/dev/chromium/src/build/secondary/third_party/trace-viewer/tracing/BUILD.gn

Syncing seems to have fix this.

This change should be good now.

Do we need a bot that runs this to avoid this bit-rot in future?

[tfarina, 2015-07-01 19:44:04]

On Wed, Jul 1, 2015 at 4:37 PM, <sbc@chromium.org> wrote:

> Do we need a bot that runs this to avoid this bit-rot in future?
>
> Brett and Nico do not think it is important. See the discussion in
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/diJmu5aIq-Q/dis...


> https://codereview.chromium.org/1216153008/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2015-07-06 17:26:39]

LGTM, thanks for tracking these down.

We shouldn't have a bot since this isn't "officially supported". Normal Chromium
committers should ever actually need this (they can use the binary GN or even
the GYP build of GN for bootstrapping).

Testing this on the bots mean that certain changes in base will make a test fail
on some bot the author has never heard of, that uses a custom script they have
to track down that's a copy of some file list in base. I don't think this is a
good requirement.

[Sam Clegg, 2015-07-06 17:47:14]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-07-06 17:49:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216153008/1

[commit-bot: I haz the power, 2015-07-06 18:00:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-06 18:01:48]

Patchset 1 (id:??) landed as
https://crrev.com/9bcde38731a3156271ec58760b3168721abbd672
Cr-Commit-Position: refs/heads/master@{#337418}