view_manager: Remove PlatformViewport abstraction.

view_manager: Remove PlatformViewport abstraction.

Remove PlatformViewport abstraction layer from view_manager, and instead
directly use ui::PlatformWindow from DefaultDisplayManager.

BUG=487881
Committed: https://crrev.com/9592672a5aefc8546757da60d6b5fd8ea09dfb3b
Cr-Commit-Position: refs/heads/master@{#337671}

[sadrul, 2015-07-06 23:36:30]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org, msw@chromium.org

[sadrul, 2015-07-06 23:36:30]

msw@ Since both ben@ and sky@ are ooo, would you mind taking a look at this?

[msw, 2015-07-07 17:23:02]

lgtm with nits and a q.

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/BUILD.gn (right):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/BUILD.gn:125: "//ui/events",
nit: abc ordering

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/display_manager.cc (left):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/display_manager.cc:199:
context_provider_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget);
q: OnAcceleratedWidgetDestroyed wasn't called, but is it no longer neeeded?

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/display_manager.cc (right):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/display_manager.cc:168: // Destroy the NativeViewport
early on as it may call us back during
nit: update NativeViewport reference? (i see others in codesearch too)

[sadrul, 2015-07-07 18:59:14]

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/BUILD.gn (right):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/BUILD.gn:125: "//ui/events",
On 2015/07/07 17:23:02, msw wrote:
> nit: abc ordering

Done.

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/display_manager.cc (left):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/display_manager.cc:199:
context_provider_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget);
On 2015/07/07 17:23:02, msw wrote:
> q: OnAcceleratedWidgetDestroyed wasn't called, but is it no longer neeeded?

Yeah, looks like it's not called anymore. I wonder if it'd make sense to call
context_provider_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget) in
::OnClosed() below?

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/display_manager.cc (right):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/display_manager.cc:168: // Destroy the NativeViewport
early on as it may call us back during
On 2015/07/07 17:23:02, msw wrote:
> nit: update NativeViewport reference? (i see others in codesearch too)

Done.

[msw, 2015-07-07 19:26:43]

still lgtm

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/display_manager.cc (left):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/display_manager.cc:199:
context_provider_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget);
On 2015/07/07 18:59:14, sadrul wrote:
> On 2015/07/07 17:23:02, msw wrote:
> > q: OnAcceleratedWidgetDestroyed wasn't called, but is it no longer neeeded?
> 
> Yeah, looks like it's not called anymore. I wonder if it'd make sense to call
> context_provider_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget) in
> ::OnClosed() below?

It might, but it doesn't seem necessary, at least for now.

[sadrul, 2015-07-07 19:49:11]

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
File components/view_manager/display_manager.cc (left):

https://codereview.chromium.org/1216113004/diff/20001/components/view_manager...
components/view_manager/display_manager.cc:199:
context_provider_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget);
On 2015/07/07 19:26:43, msw wrote:
> On 2015/07/07 18:59:14, sadrul wrote:
> > On 2015/07/07 17:23:02, msw wrote:
> > > q: OnAcceleratedWidgetDestroyed wasn't called, but is it no longer
neeeded?
> > 
> > Yeah, looks like it's not called anymore. I wonder if it'd make sense to
call
> > context_provider_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget) in
> > ::OnClosed() below?
> 
> It might, but it doesn't seem necessary, at least for now.

Sounds good. Thanks

[sadrul, 2015-07-07 19:49:16]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-07-07 19:50:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216113004/40001

[commit-bot: I haz the power, 2015-07-07 19:55:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-07 19:56:30]

Patchset 3 (id:??) landed as
https://crrev.com/9592672a5aefc8546757da60d6b5fd8ea09dfb3b
Cr-Commit-Position: refs/heads/master@{#337671}