Patch 1: Added a Chrome flag to enable Android spellchecker.

Added a Chrome flag to enable Android spellchecker.

Also enabled spellchecker libraries for Android.

BUG=415302
Committed: https://crrev.com/d7c49895dd01ef9777adfb443c61ea5eaf32bbd6
Cr-Commit-Position: refs/heads/master@{#337770}

[dylanking, 2015-07-02 03:34:24]

dylanking@google.com changed reviewers:
+ aurimas@chromium.org, rouslan@chromium.org

[dylanking, 2015-07-02 03:34:25]

Here's step one of the CL breakdown, just the Chrome flag.

More to come, but wanted to get this out before the long weekend.

[please use gerrit instead, 2015-07-02 04:09:06]

lgtm on my side. you should wait for aurimas's review as well.

[aurimas (slooooooooow), 2015-07-06 20:00:24]

This flag as it is not going to do anything, but this CL makes spell checker
always enabled. Maybe we should not make changes to build/common.gypi and
chrome/chrome_common.gypi that actually enable spellcheck as there will be no
way of disabling it otherwise. I think we can land adding this flag without
actually enabling the spellcheck. Thoughts?

[dylanking, 2015-07-06 20:04:42]

I think that's a good idea.  I can enable spellcheck in a subsequent CL (got
many more coming down the pipeline).

[aurimas (slooooooooow), 2015-07-07 04:12:23]

LGTM.

You should now add people from OWNERS files in the directories you changed.

[dylanking, 2015-07-07 21:04:42]

dylanking@google.com changed reviewers:
+ newt@chromium.org

[dylanking, 2015-07-07 21:04:43]

+newt@ for owners review of chrome/android/java/*

[newt (away), 2015-07-07 21:13:59]

lgtm after comment

https://codereview.chromium.org/1216073013/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1216073013/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.h:275: extern const char
kEnableAndroidSpellchecker[];
nit: let's be consistent with surrounding code (and with Android code) and
capitalize "Checker"

[dylanking, 2015-07-07 22:02:46]

Patchset #3 (id:40001) has been deleted

[dylanking, 2015-07-07 22:06:00]

Implemented minor style change proposed by newt@

https://codereview.chromium.org/1216073013/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1216073013/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.h:275: extern const char
kEnableAndroidSpellchecker[];
On 2015/07/07 at 21:13:59, newt wrote:
> nit: let's be consistent with surrounding code (and with Android code) and
capitalize "Checker"

Good point, done.

[dylanking, 2015-07-07 22:06:08]

The CQ bit was checked by dylanking@google.com

[dylanking, 2015-07-07 22:06:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, aurimas@chromium.org, newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1216073013/#ps60001
(title: "Minor style change to stay consistent with existing Chrome and Android
code.")

[commit-bot: I haz the power, 2015-07-07 22:07:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216073013/60001

[commit-bot: I haz the power, 2015-07-08 00:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 00:37:45]

Exceeded global retry quota

[dylanking, 2015-07-08 00:49:47]

The CQ bit was checked by dylanking@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-08 00:53:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216073013/60001

[commit-bot: I haz the power, 2015-07-08 02:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 02:00:07]

Dry run: This issue passed the CQ dry run.

[aurimas (slooooooooow), 2015-07-08 05:08:27]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-07-08 05:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216073013/60001

[commit-bot: I haz the power, 2015-07-08 05:12:44]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-07-08 05:13:34]

Patchset 3 (id:??) landed as
https://crrev.com/d7c49895dd01ef9777adfb443c61ea5eaf32bbd6
Cr-Commit-Position: refs/heads/master@{#337770}