Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1216073007: Add wrapper script for computing n-grams from SKPs on Cluster Telemetry (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@lua
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add wrapper script for computing n-grams from SKPs on Cluster Telemetry Add --n argument BUG=skia:3840 Committed: https://skia.googlesource.com/skia/+/3691e669ae77fd3d0445d4cbe9f3308e5eb9fb85

Patch Set 1 #

Patch Set 2 : Fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
A tools/lua/find_ngrams_on_ct View 1 1 chunk +61 lines, -0 lines 2 comments Download
M tools/lua/ngrams.lua View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
borenet
5 years, 5 months ago (2015-06-30 13:48:44 UTC) #2
rmistry
lgtm https://codereview.chromium.org/1216073007/diff/20001/tools/lua/find_ngrams_on_ct File tools/lua/find_ngrams_on_ct (right): https://codereview.chromium.org/1216073007/diff/20001/tools/lua/find_ngrams_on_ct#newcode43 tools/lua/find_ngrams_on_ct:43: tmp_script.close() Move the close into the finally?
5 years, 5 months ago (2015-06-30 17:05:13 UTC) #3
borenet
https://codereview.chromium.org/1216073007/diff/20001/tools/lua/find_ngrams_on_ct File tools/lua/find_ngrams_on_ct (right): https://codereview.chromium.org/1216073007/diff/20001/tools/lua/find_ngrams_on_ct#newcode43 tools/lua/find_ngrams_on_ct:43: tmp_script.close() On 2015/06/30 17:05:12, rmistry wrote: > Move the ...
5 years, 5 months ago (2015-06-30 17:16:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216073007/20001
5 years, 5 months ago (2015-06-30 17:16:52 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 17:24:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3691e669ae77fd3d0445d4cbe9f3308e5eb9fb85

Powered by Google App Engine
This is Rietveld 408576698