Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1216063004: This CL adds support for ARM and ARM64 architectures when calculating (Closed)

Created:
5 years, 5 months ago by liuandrew
Modified:
5 years, 5 months ago
Reviewers:
srutherford, ahonig, ivanpe
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

This CL adds support for ARM and ARM64 architectures when calculating exploitability ratings. The stackwalker will now grab the instruction pointers for ARM and ARM64 architectures, so checking exploitability on ARM and ARM64 will no longer return EXPLOITABILITY_ERR_PROCESSING. R=ivanpe@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1466

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/processor/exploitability_linux.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
liuandrew
5 years, 5 months ago (2015-06-30 00:50:43 UTC) #2
ivanpe
https://codereview.chromium.org/1216063004/diff/1/src/processor/exploitability_linux.cc File src/processor/exploitability_linux.cc (right): https://codereview.chromium.org/1216063004/diff/1/src/processor/exploitability_linux.cc#newcode113 src/processor/exploitability_linux.cc:113: instruction_ptr = context->GetContextARM64()->iregs[MD_CONTEXT_ARM64_REG_PC]; Please, keep lines shorter than 80 ...
5 years, 5 months ago (2015-06-30 01:05:08 UTC) #3
liuandrew
Broke apart long lines. https://codereview.chromium.org/1216063004/diff/1/src/processor/exploitability_linux.cc File src/processor/exploitability_linux.cc (right): https://codereview.chromium.org/1216063004/diff/1/src/processor/exploitability_linux.cc#newcode113 src/processor/exploitability_linux.cc:113: instruction_ptr = context->GetContextARM64()->iregs[MD_CONTEXT_ARM64_REG_PC]; On 2015/06/30 ...
5 years, 5 months ago (2015-06-30 16:14:17 UTC) #4
ivanpe
LGTM
5 years, 5 months ago (2015-06-30 17:35:47 UTC) #5
liuandrew
5 years, 5 months ago (2015-06-30 18:17:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r1466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698