Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 1216053014: Add WebPointerEvent, WebMouseProperties and WebPointerProperties types. (Closed)

Created:
5 years, 5 months ago by USE eero AT chromium.org
Modified:
5 years, 5 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebPointerEvent, WebMouseProperties and WebPointerProperties types. This add a WebPointerEvent type. This also adds WebMouseProperties and WebPointerProperties types as common types which are inherited by WebMouseEvent, WebPointerEvent and WebTouchPoint. The latter change causes WebTouchPoint field names to change. This CL is a part of a three-sided patchset: 1. https://codereview.chromium.org/1216053014/ <-- this patch 2. https://codereview.chromium.org/1218663006/ 3. https://codereview.chromium.org/1212113007/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -58 lines) Patch
M Source/web/WebInputEvent.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 10 chunks +27 lines, -27 lines 0 comments Download
M public/web/WebInputEvent.h View 6 chunks +17 lines, -11 lines 0 comments Download
A public/web/WebMouseProperties.h View 1 chunk +32 lines, -0 lines 0 comments Download
A public/web/WebPointerProperties.h View 1 chunk +44 lines, -0 lines 0 comments Download
M public/web/WebTouchPoint.h View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
USE eero AT chromium.org
PTAL. As this is only an intermediate CL, it might be easier to look https://codereview.chromium.org/1212113007/ ...
5 years, 5 months ago (2015-07-06 16:44:43 UTC) #2
USE eero AT chromium.org
PTAL. As this is only an intermediate CL, it might be easier to look https://codereview.chromium.org/1212113007/ ...
5 years, 5 months ago (2015-07-06 16:44:49 UTC) #3
USE eero AT chromium.org
5 years, 5 months ago (2015-07-07 10:04:14 UTC) #4
Three-sided patch set is not needed, after all.

Powered by Google App Engine
This is Rietveld 408576698