Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216053009: Semi-evil multicol performance test. (Closed)

Created:
5 years, 5 months ago by mstensho (USE GERRIT)
Modified:
5 years, 5 months ago
Reviewers:
dsinclair
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Semi-evil multicol performance test. It contains some deeply nested tables, and currently it also triggers 3 layout passes, while 2 should in theory be enough. For each layout pass we currently also do a deep layout (thanks to markForPaginationRelayoutIfNeeded() pretty much always marking everything for layout). That should be improved as part of fixing bug 487026. R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
A PerformanceTests/Layout/multicol/fixed-height-with-spanner-and-nested-tables.html View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 5 months ago (2015-07-01 13:59:12 UTC) #1
dsinclair
lgtm
5 years, 5 months ago (2015-07-02 13:59:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216053009/1
5 years, 5 months ago (2015-07-02 13:59:29 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 15:32:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198221

Powered by Google App Engine
This is Rietveld 408576698