Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216033008: Revert "Move headers used by headers in include/ to include/private." (Closed)

Created:
5 years, 5 months ago by jvanverth1
Modified:
5 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Move headers used by headers in include/ to include/private." This reverts commit a89f55198bdc58f0b6f6196907ab25a6afc1a661. Reason: breaking the roll. TBR=mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/4417c7f8bb85aa1eae536cc50c70c0cc87f31171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1240 lines) Patch
M PRESUBMIT.py View 2 chunks +4 lines, -10 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/debugger.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/dm.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/example.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gputest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pdf.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/ports.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/svg.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tools.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M gyp/utils.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/visualbench.gyp View 3 chunks +2 lines, -3 lines 0 comments Download
M gyp/xps.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPictureRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrBlend.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkGLContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
D include/private/SkChecksum.h View 1 chunk +0 lines, -198 lines 0 comments Download
D include/private/SkFunction.h View 1 chunk +0 lines, -75 lines 0 comments Download
D include/private/SkGpuFenceSync.h View 1 chunk +0 lines, -29 lines 0 comments Download
D include/private/SkMiniRecorder.h View 1 chunk +0 lines, -50 lines 0 comments Download
D include/private/SkPathPriv.h View 1 chunk +0 lines, -64 lines 0 comments Download
D include/private/SkRecords.h View 1 chunk +0 lines, -392 lines 0 comments Download
D include/private/SkTHash.h View 1 chunk +0 lines, -292 lines 0 comments Download
D include/private/SkTLogic.h View 1 chunk +0 lines, -111 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/core/SkChecksum.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkFunction.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkMiniRecorder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkPathPriv.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkRecords.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkTHash.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/SkGpuFenceSync.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/utils/SkTLogic.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216033008/1
5 years, 5 months ago (2015-07-01 16:45:28 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 16:45:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4417c7f8bb85aa1eae536cc50c70c0cc87f31171

Powered by Google App Engine
This is Rietveld 408576698