Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1216033005: Convert remoting_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@12_wm_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert remoting_unittests to run exclusively on Swarming 0 configs already ran on Swarming 28 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert remoting_unittests R=lambroslambrou@chromium.org,dpranke@chromium.org TBR= BUG=98637 Committed: https://crrev.com/f25c68c20a42a05981410fd9159cebe162ff7865 Cr-Commit-Position: refs/heads/master@{#336931}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add necessary certificates #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -3 lines) Patch
M build/gn_migration.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 1 chunk +18 lines, -1 line 0 comments Download
A + remoting/remoting_unittests.isolate View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
M-A Ruel
5 years, 5 months ago (2015-06-30 19:44:16 UTC) #1
Lambros
Anand, can you take a look?
5 years, 5 months ago (2015-06-30 20:14:49 UTC) #3
anandc
On 2015/06/30 20:14:49, Lambros wrote: > Anand, can you take a look? Thanks M-A. LGTM.
5 years, 5 months ago (2015-06-30 20:43:57 UTC) #4
Lambros
On 2015/06/30 20:43:57, anandc wrote: > On 2015/06/30 20:14:49, Lambros wrote: > > Anand, can ...
5 years, 5 months ago (2015-06-30 20:47:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216033005/60001
5 years, 5 months ago (2015-06-30 23:13:47 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-01 00:21:14 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f25c68c20a42a05981410fd9159cebe162ff7865 Cr-Commit-Position: refs/heads/master@{#336931}
5 years, 5 months ago (2015-07-01 00:22:14 UTC) #10
Dirk Pranke
5 years, 5 months ago (2015-07-01 19:38:12 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698