Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: src/IceTargetLoweringX8632.h

Issue 1216033004: Move X8632-specific Assembler stuff to Machine Traits. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Removes references to X8632-specific registers/condition codes from the base TargetLoweringX86Base. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringX8632.h
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index 30f6e6e0b7d4beec0b63259eadab592a0a0065cd..f24275dd1cc935e8aa9db56807e3c9c975d75380 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -21,6 +21,7 @@
#include "IceInstX8632.h"
#include "IceRegistersX8632.h"
#include "IceTargetLowering.h"
+#include "IceTargetLoweringX8632Traits.h"
namespace Ice {
@@ -30,16 +31,11 @@ class TargetX8632 : public TargetLowering {
TargetX8632 &operator=(const TargetX8632 &) = delete;
public:
- enum X86InstructionSet {
- Begin,
- // SSE2 is the PNaCl baseline instruction set.
- SSE2 = Begin,
- SSE4_1,
- End
- };
+ using X86InstructionSet = X8632::Traits::InstructionSet;
static TargetX8632 *create(Cfg *Func);
- virtual X8632::Address stackVarToAsmOperand(const Variable *Var) const = 0;
+ virtual X8632::Traits::Address
+ stackVarToAsmOperand(const Variable *Var) const = 0;
virtual X86InstructionSet getInstructionSet() const = 0;
protected:

Powered by Google App Engine
This is Rietveld 408576698