Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/IceRegistersX8664.h

Issue 1216033004: Move X8632-specific Assembler stuff to Machine Traits. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceRegistersX8632.h ('k') | src/IceTargetLoweringX8632.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceRegistersX8664.h
diff --git a/src/IceRegistersX8664.h b/src/IceRegistersX8664.h
index 96567b270ed6a05047f12ae17579a39aa6f4de1a..ceafc8639e42f3661ee396f0c3901f0255824571 100644
--- a/src/IceRegistersX8664.h
+++ b/src/IceRegistersX8664.h
@@ -20,79 +20,78 @@
namespace Ice {
-namespace RegX8664 {
-
-// An enum of every register. The enum value may not match the encoding
-// used to binary encode register operands in instructions.
-enum AllRegisters {
+class RegX8664 {
+public:
+ // An enum of every register. The enum value may not match the encoding
+ // used to binary encode register operands in instructions.
+ enum AllRegisters {
#define X(val, encode, name64, name, name16, name8, scratch, preserved, \
stackptr, frameptr, isInt, isFP) \
val,
- REGX8664_TABLE
+ REGX8664_TABLE
#undef X
- Reg_NUM,
+ Reg_NUM,
#define X(val, init) val init,
- REGX8664_TABLE_BOUNDS
+ REGX8664_TABLE_BOUNDS
#undef X
-};
+ };
-// An enum of GPR Registers. The enum value does match the encoding used
-// to binary encode register operands in instructions.
-enum GPRRegister {
+ // An enum of GPR Registers. The enum value does match the encoding used
+ // to binary encode register operands in instructions.
+ enum GPRRegister {
#define X(val, encode, name64, name, name16, name8, scratch, preserved, \
stackptr, frameptr, isInt, isFP) \
Encoded_##val encode,
- REGX8664_GPR_TABLE
+ REGX8664_GPR_TABLE
#undef X
- Encoded_Not_GPR = -1
-};
+ Encoded_Not_GPR = -1
+ };
-// An enum of XMM Registers. The enum value does match the encoding used
-// to binary encode register operands in instructions.
-enum XmmRegister {
+ // An enum of XMM Registers. The enum value does match the encoding used
+ // to binary encode register operands in instructions.
+ enum XmmRegister {
#define X(val, encode, name64, name, name16, name8, scratch, preserved, \
stackptr, frameptr, isInt, isFP) \
Encoded_##val encode,
- REGX8664_XMM_TABLE
+ REGX8664_XMM_TABLE
#undef X
- Encoded_Not_Xmm = -1
-};
+ Encoded_Not_Xmm = -1
+ };
-// An enum of Byte Registers. The enum value does match the encoding used
-// to binary encode register operands in instructions.
-enum ByteRegister {
+ // An enum of Byte Registers. The enum value does match the encoding used
+ // to binary encode register operands in instructions.
+ enum ByteRegister {
#define X(val, encode) Encoded_##val encode,
- REGX8664_BYTEREG_TABLE
+ REGX8664_BYTEREG_TABLE
#undef X
- Encoded_Not_ByteReg = -1
-};
-
-static inline GPRRegister getEncodedGPR(int32_t RegNum) {
- assert(Reg_GPR_First <= RegNum && RegNum <= Reg_GPR_Last);
- return GPRRegister(RegNum - Reg_GPR_First);
-}
+ Encoded_Not_ByteReg = -1
+ };
-static inline XmmRegister getEncodedXmm(int32_t RegNum) {
- assert(Reg_XMM_First <= RegNum && RegNum <= Reg_XMM_Last);
- return XmmRegister(RegNum - Reg_XMM_First);
-}
+ static inline GPRRegister getEncodedGPR(int32_t RegNum) {
+ assert(Reg_GPR_First <= RegNum && RegNum <= Reg_GPR_Last);
+ return GPRRegister(RegNum - Reg_GPR_First);
+ }
-static inline ByteRegister getEncodedByteReg(int32_t RegNum) {
- // In x86-64, AH is not encodable when the REX prefix is used; the same
- // encoding is used for spl. Therefore, ah needs special handling.
- if (RegNum == Reg_ah)
- return Encoded_Reg_spl;
- return ByteRegister(RegNum - Reg_GPR_First);
-}
+ static inline XmmRegister getEncodedXmm(int32_t RegNum) {
+ assert(Reg_XMM_First <= RegNum && RegNum <= Reg_XMM_Last);
+ return XmmRegister(RegNum - Reg_XMM_First);
+ }
-static inline GPRRegister getEncodedByteRegOrGPR(Type Ty, int32_t RegNum) {
- if (isByteSizedType(Ty))
- return GPRRegister(getEncodedByteReg(RegNum));
- else
- return getEncodedGPR(RegNum);
-}
+ static inline ByteRegister getEncodedByteReg(int32_t RegNum) {
+ // In x86-64, AH is not encodable when the REX prefix is used; the same
+ // encoding is used for spl. Therefore, ah needs special handling.
+ if (RegNum == Reg_ah)
+ return Encoded_Reg_spl;
+ return ByteRegister(RegNum - Reg_GPR_First);
+ }
-} // end of namespace RegX8664
+ static inline GPRRegister getEncodedByteRegOrGPR(Type Ty, int32_t RegNum) {
+ if (isByteSizedType(Ty))
+ return GPRRegister(getEncodedByteReg(RegNum));
+ else
+ return getEncodedGPR(RegNum);
+ }
+};
} // end of namespace Ice
« no previous file with comments | « src/IceRegistersX8632.h ('k') | src/IceTargetLoweringX8632.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698