Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1215973005: [es6] Reenable new.target + Reflect.construct tests (Closed)

Created:
5 years, 5 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
Reviewers:
caitp (gmail), adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Reenable new.target + Reflect.construct tests BUG=v8:3887 LOG=N R=caitpotter88@gmail.com, adamk@chromium.org Committed: https://crrev.com/b87cef133f55666d3d5ff1675c1ffdfc13956ac3 Cr-Commit-Position: refs/heads/master@{#29359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/mjsunit/harmony/new-target.js View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
arv (Not doing code reviews)
PTAL I ran the tests on ia32, x64, arm, arm64, mips & mips64
5 years, 5 months ago (2015-06-29 18:52:30 UTC) #1
adamk
lgtm
5 years, 5 months ago (2015-06-29 18:52:53 UTC) #2
caitp (gmail)
On 2015/06/29 18:52:53, adamk wrote: > lgtm lgtm --- I think this probably means the ...
5 years, 5 months ago (2015-06-29 18:54:18 UTC) #3
arv (Not doing code reviews)
On 2015/06/29 18:54:18, caitp wrote: > On 2015/06/29 18:52:53, adamk wrote: > > lgtm > ...
5 years, 5 months ago (2015-06-29 19:09:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215973005/1
5 years, 5 months ago (2015-06-29 19:10:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 19:12:06 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 19:12:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b87cef133f55666d3d5ff1675c1ffdfc13956ac3
Cr-Commit-Position: refs/heads/master@{#29359}

Powered by Google App Engine
This is Rietveld 408576698