Source/web/tests/PinchViewportTest.cpp - Issue 1215973002: Oilpan: improve ScrollableArea handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/PinchViewportTest.cpp

Issue 1215973002: Oilpan: improve ScrollableArea handling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review-induced improvements Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/PinchViewportTest.cpp

diff --git a/Source/web/tests/PinchViewportTest.cpp b/Source/web/tests/PinchViewportTest.cpp

index 4f5e3f2628fd4884c1425d771519af305cac714a..d0917e6ac069fbf306de67b9e16941e678cbd764 100644

--- a/Source/web/tests/PinchViewportTest.cpp

+++ b/Source/web/tests/PinchViewportTest.cpp

@@ -208,11 +208,6 @@ public:

}

};

-#if OS(MACOSX) && ENABLE(OILPAN)

-// FIXME(504655): RootLayerScrolls configuration crashes on Mac Oilpan bots.

-INSTANTIATE_TEST_CASE_P(All, ParameterizedPinchViewportTest, ::testing::Values(

- DefaultSettingOverride));

-#else

static void RootLayerScrollsSettingOverride(WebSettings *settings)

{

settings->setRootLayerScrolls(true);

@@ -220,7 +215,6 @@ static void RootLayerScrollsSettingOverride(WebSettings *settings)

INSTANTIATE_TEST_CASE_P(All, ParameterizedPinchViewportTest, ::testing::Values(

DefaultSettingOverride,

RootLayerScrollsSettingOverride));

-#endif

// Test that resizing the PinchViewport works as expected and that resizing the

// WebView resizes the PinchViewport.

« no previous file with comments | « Source/web/ViewportAnchor.h ('k') | Source/web/tests/ScrollAnimatorNoneTest.cpp » ('j') | no next file with comments »