Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1215973002: Oilpan: improve ScrollableArea handling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove too conservative null check Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/DeprecatedPaintLayer.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayer.cpp b/Source/core/paint/DeprecatedPaintLayer.cpp
index aa33334b5a63398d298be41c12dcfda82f610cba..66a0aefac2b63310da6eec9fdbc16039c43862fb 100644
--- a/Source/core/paint/DeprecatedPaintLayer.cpp
+++ b/Source/core/paint/DeprecatedPaintLayer.cpp
@@ -171,6 +171,9 @@ DeprecatedPaintLayer::~DeprecatedPaintLayer()
if (m_reflectionInfo)
m_reflectionInfo->destroy();
+
+ if (m_scrollableArea)
+ m_scrollableArea->dispose();
}
String DeprecatedPaintLayer::debugName() const
@@ -1442,7 +1445,7 @@ void DeprecatedPaintLayer::updateStackingNode()
void DeprecatedPaintLayer::updateScrollableArea()
{
if (requiresScrollableArea())
- m_scrollableArea = adoptPtr(new DeprecatedPaintLayerScrollableArea(*this));
+ m_scrollableArea = DeprecatedPaintLayerScrollableArea::create(*this);
else
m_scrollableArea = nullptr;
haraken 2015/06/29 15:20:21 Don't we need to call m_scrollableArea->dispose()
sof 2015/06/29 15:59:41 I'm not familiar with the naming for this helper,
}

Powered by Google App Engine
This is Rietveld 408576698