Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: sky/engine/tonic/dart_library_loader.cc

Issue 1215953006: Use sky_shell instead of mojo_shell for testing. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Foo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/tonic/dart_library_loader.cc
diff --git a/sky/engine/tonic/dart_library_loader.cc b/sky/engine/tonic/dart_library_loader.cc
index e99862a7633ff6d201cbe8cce522b6ce64ace5b7..44f49de3dc3ec0ab5a36757aa4d3ee565e4c07cc 100644
--- a/sky/engine/tonic/dart_library_loader.cc
+++ b/sky/engine/tonic/dart_library_loader.cc
@@ -242,9 +242,13 @@ void DartLibraryLoader::DidCompleteImportJob(ImportJob* job,
WatcherSignaler watcher_signaler(*this, job);
- LogIfError(Dart_LoadLibrary(
+ Dart_Handle result = Dart_LoadLibrary(
StringToDart(dart_state_, job->name()),
- Dart_NewStringFromUTF8(buffer.data(), buffer.size()), 0, 0));
+ Dart_NewStringFromUTF8(buffer.data(), buffer.size()), 0, 0);
+ if (Dart_IsError(result)) {
+ LOG(ERROR) << "Error Loading " << job->name().utf8().data() << " "
+ << Dart_GetError(result);
+ }
pending_libraries_.remove(job->name());
jobs_.remove(job);
@@ -257,10 +261,15 @@ void DartLibraryLoader::DidCompleteSourceJob(SourceJob* job,
WatcherSignaler watcher_signaler(*this, job);
- LogIfError(Dart_LoadSource(
+ Dart_Handle result = Dart_LoadSource(
Dart_HandleFromPersistent(job->library()),
StringToDart(dart_state_, job->name()),
- Dart_NewStringFromUTF8(buffer.data(), buffer.size()), 0, 0));
+ Dart_NewStringFromUTF8(buffer.data(), buffer.size()), 0, 0);
+
+ if (Dart_IsError(result)) {
+ LOG(ERROR) << "Error Loading " << job->name().utf8().data() << " "
+ << Dart_GetError(result);
+ }
jobs_.remove(job);
}
« no previous file with comments | « no previous file | sky/services/ns_net/network_service_impl.h » ('j') | sky/shell/dart/dart_library_provider_files.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698