Issue 1215953003: Construct Internals with a ScriptState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1215953003: Construct Internals with a ScriptState (Closed)

Created:
5 years, 5 months ago by domenic

Modified:
5 years, 5 months ago

Reviewers:
haraken, vivekg

CC:
vivekg, arv+blink, blink-reviews, Inactive, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Construct Internals with a ScriptState This replaces the Document it previously took. It allows Internals to contain objects which depend on ScriptState, like ScriptPromise or (in the future) ReadableStream. BUG= R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197977

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -7 lines)			Patch
M	Source/core/testing/Internals.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/testing/Internals.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/testing/v8/WebCoreTestSupport.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215953003/1

5 years, 5 months ago (2015-06-29 09:06:30 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-06-29 11:05:12 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197977