Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: net/tools/flip_server/loadtime_measurement.h

Issue 1215933004: New new versions of Starts/EndsWith and SplitString in net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/flip_server/flip_in_mem_edsm_server.cc ('k') | net/tools/gdig/gdig.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/flip_server/loadtime_measurement.h
diff --git a/net/tools/flip_server/loadtime_measurement.h b/net/tools/flip_server/loadtime_measurement.h
index d18ac2f897d47e86a262149078a5df492fc739b5..d1a8e07fdb267a0eb2cafb610293adb01f6298c8 100644
--- a/net/tools/flip_server/loadtime_measurement.h
+++ b/net/tools/flip_server/loadtime_measurement.h
@@ -30,7 +30,8 @@ class LoadtimeMeasurement {
: num_urls_(0), pageload_html_file_(pageload_html_file) {
std::string urls_string;
base::ReadFileToString(urls_file, &urls_string);
- base::SplitString(urls_string, '\n', &urls_);
+ urls_ = base::SplitString(urls_string, "\n", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL);
num_urls_ = urls_.size();
}
@@ -72,14 +73,14 @@ class LoadtimeMeasurement {
return;
}
if (action.find("record_page_load") == 0) {
- std::vector<std::string> query;
- base::SplitString(action, '?', &query);
- std::vector<std::string> params;
- base::SplitString(query[1], '&', &params);
- std::vector<std::string> url;
- std::vector<std::string> loadtime;
- base::SplitString(params[1], '=', &url);
- base::SplitString(params[2], '=', &loadtime);
+ std::vector<std::string> query = base::SplitString(
+ action, "?", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> params = base::SplitString(
+ query[1], "&", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> url = base::SplitString(
+ params[1], "=", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> loadtime = base::SplitString(
+ params[2], "=", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
loadtimes_[url[1]] = atoi(loadtime[1].c_str());
output.append("OK");
return;
« no previous file with comments | « net/tools/flip_server/flip_in_mem_edsm_server.cc ('k') | net/tools/gdig/gdig.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698