net/http/http_auth_cache.cc - Issue 1215933004: New new versions of Starts/EndsWith and SplitString in net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_cache.cc

Issue 1215933004: New new versions of Starts/EndsWith and SplitString in net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_cache.cc

diff --git a/net/http/http_auth_cache.cc b/net/http/http_auth_cache.cc

index 56ce99efafdbd72b541585dc4d525fe9ce3a5cae..d76d3ed40cd5dd912a87938c13c5bebdef952c99 100644

--- a/net/http/http_auth_cache.cc

+++ b/net/http/http_auth_cache.cc

@@ -37,7 +37,8 @@ void CheckPathIsValid(const std::string& path) {

bool IsEnclosingPath(const std::string& container, const std::string& path) {

DCHECK(container.empty() || *(container.end() - 1) == '/');

return ((container.empty() && path.empty()) ||

- (!container.empty() && base::StartsWithASCII(path, container, true)));

+ (!container.empty() &&

+ base::StartsWith(path, container, base::CompareCase::SENSITIVE)));

}

// Debug helper to check that |origin| arguments are properly formed.

« no previous file with comments | « net/ftp/ftp_util.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »