Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: net/dns/dns_config_service_unittest.cc

Issue 1215933004: New new versions of Starts/EndsWith and SplitString in net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_config_service_unittest.cc
diff --git a/net/dns/dns_config_service_unittest.cc b/net/dns/dns_config_service_unittest.cc
index 0ff0b912569e0aabb4495539afe8a346b307ea42..ed6d86d7a99a2abd2839dbb0e3fcd42eed3da4ff 100644
--- a/net/dns/dns_config_service_unittest.cc
+++ b/net/dns/dns_config_service_unittest.cc
@@ -37,18 +37,15 @@ class NameServerClassifierTest : public testing::Test {
protected:
NameServerClassifier::NameServersType Classify(
const std::string& servers_string) {
- std::vector<std::string> server_strings;
- base::SplitString(servers_string, ' ', &server_strings);
-
std::vector<IPEndPoint> servers;
- for (std::vector<std::string>::const_iterator it = server_strings.begin();
- it != server_strings.end();
- ++it) {
- if (it->empty())
+ for (const base::StringPiece& server_str :
+ base::SplitStringPiece(servers_string, " ", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL)) {
+ if (server_str.empty())
continue;
IPAddressNumber address;
- bool parsed = ParseIPLiteralToNumber(*it, &address);
+ bool parsed = ParseIPLiteralToNumber(server_str, &address);
EXPECT_TRUE(parsed);
servers.push_back(IPEndPoint(address, dns_protocol::kDefaultPort));
}
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698