New new versions of Starts/EndsWith and SplitString in net

net/dns/dns_config_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_config_service.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/cancelable_callback.h"
 #include "base/location.h"
@@ skipping 19 matching lines @@
     NameServerClassifier::NAME_SERVERS_TYPE_PRIVATE;
 const NameServerClassifier::NameServersType kPublic =
     NameServerClassifier::NAME_SERVERS_TYPE_PUBLIC;
 const NameServerClassifier::NameServersType kMixed =
     NameServerClassifier::NAME_SERVERS_TYPE_MIXED;
 
 class NameServerClassifierTest : public testing::Test {
  protected:
   NameServerClassifier::NameServersType Classify(
       const std::string& servers_string) {
-    std::vector<std::string> server_strings;
-    base::SplitString(servers_string, ' ', &server_strings);
-
     std::vector<IPEndPoint> servers;
-    for (std::vector<std::string>::const_iterator it = server_strings.begin();
-         it != server_strings.end();
-         ++it) {
-      if (it->empty())
+    for (const base::StringPiece& server_str :
+         base::SplitStringPiece(servers_string, " ", base::TRIM_WHITESPACE,
+                                base::SPLIT_WANT_ALL)) {
+      if (server_str.empty())
         continue;
 
       IPAddressNumber address;
-      bool parsed = ParseIPLiteralToNumber(*it, &address);
+      bool parsed = ParseIPLiteralToNumber(server_str, &address);
       EXPECT_TRUE(parsed);
       servers.push_back(IPEndPoint(address, dns_protocol::kDefaultPort));
     }
 
     return classifier_.GetNameServersType(servers);
   }
 
  private:
   NameServerClassifier classifier_;
 };
@@ skipping 268 matching lines @@
 
   last_config_ = bad_config;
   // No change, so no update.
   service_->InvalidateConfig();
   service_->OnConfigRead(config2);
   EXPECT_TRUE(last_config_.Equals(bad_config));
 }
 
 }  // namespace net